Updates beacon agent on-prem DSN examples #6213
Conversation
ksnavely
force-pushed
the
UPM-40771-agent-docs
branch
3 times, most recently
from
932d3e4 to
6a7d76b
Compare
advocacy_docs/edb-postgres-ai/console/estate/agent/install-agent.mdx
Outdated
Show resolved
Hide resolved
| @@ -158,8 +158,7 @@ agent: | |||
| provider: | |||
| onprem: | |||
| databases: | |||
| sales_reporting: | |||
| dsn: "$DSN" | |||
| - dsn: "$DSN" | |||
There was a problem hiding this comment.
In https://github.com/EnterpriseDB/docs/pull/6105/files a resource_id key is used; are we skipping it here for compactness?
There was a problem hiding this comment.
Resource id is an allowed field according to the code https://github.com/EnterpriseDB/upm-beacon/blob/79f12896839dd5c8898c97c4ef2591645de57a99/internal/config/agent.go#L211
It is an optional field though, and doesn't need to be specified.
There was a problem hiding this comment.
This PR looks totally valid https://github.com/EnterpriseDB/docs/pull/6105/files
There was a problem hiding this comment.
Well, yes but it also conflicts with your edits which is what I want to resolve. Given the edits in here, I'd like to promote this PR and ensure nothing is lost from the other PR before we close it.
advocacy_docs/edb-postgres-ai/console/estate/agent/install-agent.mdx
Outdated
Show resolved
Hide resolved
| tags: | ||
| - "<tag-one>" | ||
| - "<tag-two>" | ||
| - dsn: "$DSN1" |
There was a problem hiding this comment.
As above - we have another PR where resource_id is used. The other option is that resource_id has been dropped, so in that case we should have a formal reference for the yaml in here.
djw-m
force-pushed
the
UPM-40771-agent-docs
branch
from
6d1cef9 to
da8c401
Compare
|
I think this PR can be closed based on our conversation. |
|
Happy to review and merge this one (as it has other fixes). We can doc resource_id properly elsewhere. |
ksnavely
force-pushed
the
UPM-40771-agent-docs
branch
from
d5913f4 to
e7f92a4
Compare
gvasquezvargas
force-pushed
the
UPM-40771-agent-docs
branch
from
e7f92a4 to
01e919d
Compare
What Changed?
These changes are aligned with upcoming product capabilities.
I've also eliminated trailing whitespaces in the touched docs.